Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping support for older versions of Ruby #325

Closed
floehopper opened this issue Mar 16, 2018 · 9 comments
Closed

Consider dropping support for older versions of Ruby #325

floehopper opened this issue Mar 16, 2018 · 9 comments
Milestone
2.0.0

Comments

@floehopper
Copy link
Member

Ideally come up with rules to define how this works.

Some useful references:
@floehopper
Copy link
Member Author

Extended maintenance of Ruby versions 1.8.7 and 1.9.2 will end on July 31, 2014.

@floehopper floehopper mentioned this issue Jun 17, 2019
Closed
@nitishr
Copy link
Contributor

nitishr commented Oct 15, 2019

Why aren't we dropping support for at least 1.8.7 already? It hasn't even been possible for me to run bundle exec rake with 1.8.7 due to the difficulty of installing the right combination of gems and libraries.

This would also help clean up some code as well as close some open issues.

floehopper added a commit that referenced this issue Nov 23, 2019
@floehopper
Deprecate support for Ruby versions earlier than v1.9
c5f8496 
This is long overdue. Extended maintenance of Ruby v1.8.7 ended on 31
Jul 2014 [1]. Actually dropping support will allow significant
simplification of the code.

See #325.

[1]: https://www.ruby-lang.org/en/news/2014/07/01/eol-for-1-8-7-and-1-9-2/
@floehopper
Copy link
Member Author

Why aren't we dropping support for at least 1.8.7 already?

No good reason. I think I was just agonising over how to deal with it within the confines of semantic versioning. I've just done this in c5f8496.

It hasn't even been possible for me to run bundle exec rake with 1.8.7 due to the difficulty of installing the right combination of gems and libraries.

That's odd. Did you try deleting your Gemfile.lock before running bundle install? That seems to work for me locally.

This would also help clean up some code as well as close some open issues.

I agree. Thanks for the prompt!

@floehopper floehopper mentioned this issue Dec 23, 2020
Closed
@floehopper
Copy link
Member Author

Extended maintenance of Ruby v1.8.7 ended on 31 Jul 2014 and Mocha support for Ruby v1.8 has been deprecated since v1.10. Recent work in #534 has run into problems with files containing keyword arguments not being parsable by Ruby v1.8 and so I think the time has come to drop support.

@floehopper
Copy link
Member Author

I've just dropped support for Ruby v1.8 in #536. There's still some question about whether that should be a minor or major version release, but that decision can wait for now.

@floehopper
Copy link
Member Author

Support for Ruby version 1.9.3 ended on February 23, 2015.

floehopper pushed a commit that referenced this issue Sep 20, 2022
@wasabigeek @floehopper
Deprecate support for Ruby versions earlier than v2.0
9a5d462 
This is long overdue. Extended maintenance of Ruby v1.9.3 ended on 23
Feb 2015 [1]. Actually dropping support will allow significant
simplification of the code.

The immediate motivation is to come up with better parameter matching
for keyword arguments and we've run into parsing issues when trying to
do this in conjunction with continuing to support Ruby v1.9.

See #325.

[1]: https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/
floehopper pushed a commit that referenced this issue Sep 20, 2022
@wasabigeek @floehopper
Deprecate support for Ruby versions earlier than v2.0
daf8257 
This is long overdue. Extended maintenance of Ruby v1.9.3 ended on 23
Feb 2015 [1]. Actually dropping support will allow significant
simplification of the code.

The immediate motivation is to come up with better parameter matching
for keyword arguments and we've run into parsing issues when trying to
do this in conjunction with continuing to support Ruby v1.9.

See #325.

[1]: https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/
floehopper pushed a commit that referenced this issue Sep 20, 2022
@wasabigeek @floehopper
Deprecate support for Ruby versions earlier than v2.0
185a7bf 
This is long overdue. Extended maintenance of Ruby v1.9.3 ended on 23
Feb 2015 [1]. Actually dropping support will allow significant
simplification of the code.

The immediate motivation is to come up with better parameter matching
for keyword arguments and we've run into parsing issues when trying to
do this in conjunction with continuing to support Ruby v1.9.

See #325.

[1]: https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/
@floehopper floehopper mentioned this issue Sep 20, 2022
Merged
floehopper pushed a commit that referenced this issue Sep 21, 2022
@wasabigeek @floehopper
Deprecate support for Ruby versions earlier than v2.0
b98b122 
This is long overdue. Extended maintenance of Ruby v1.9.3 ended on 23
Feb 2015 [1]. Actually dropping support will allow significant
simplification of the code.

The immediate motivation is to come up with better parameter matching
for keyword arguments and we've run into parsing issues when trying to
do this in conjunction with continuing to support Ruby v1.9.

Requiring 'mocha/ruby_version' from 'mocha/test_unit', 'mocha/minitest'
and 'mocha/api' is intended to ensure the deprecation warning appears at
the earliest possible time whether the library is being used via
Test::Unit, Minitest or RSpec.

See #325.

[1]: https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/
floehopper pushed a commit that referenced this issue Sep 21, 2022
@wasabigeek @floehopper
Deprecate support for Ruby versions earlier than v2.0
d752f09 
This is long overdue. Extended maintenance of Ruby v1.9.3 ended on 23
Feb 2015 [1]. Actually dropping support will allow significant
simplification of the code.

The immediate motivation is to come up with better parameter matching
for keyword arguments and we've run into parsing issues when trying to
do this in conjunction with continuing to support Ruby v1.9.

Requiring 'mocha/ruby_version' from 'mocha/test_unit', 'mocha/minitest'
and 'mocha/api' is intended to ensure the deprecation warning appears at
the earliest possible time whether the library is being used via
Test::Unit, Minitest or RSpec.

See #325.

[1]: https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/
@wasabigeek wasabigeek mentioned this issue Sep 22, 2022
Closed
@floehopper floehopper added this to the 2.0.0 milestone Oct 13, 2022
@floehopper
Copy link
Member Author

I've just dropped support for Ruby v1.8 in #536. There's still some question about whether that should be a minor or major version release, but that decision can wait for now.

Hmm. I'm not sure how conscious the decision was, but the dropping of support for Ruby v1.8 ended up being in a minor version bump!

@floehopper
Copy link
Member Author

From the rspec-rails versioning strategy:

For the purposes of this versioning strategy, we consider removing a Rails or Ruby version to be a breaking change.

@floehopper
Copy link
Member Author

For Mocha v2.0, I'm happy that we should drop support for Ruby versions earlier than Ruby v2.0.

  • Support for Ruby < v1.9 was deprecated in c5f8496, dropped in ddb5d67, and released in Mocha v1.15.0.
  • Support for Ruby < v2.0 was deprecated in d752f09, dropped in 26c4ae1, and will be released in Mocha v2.0.

I don't think it's worth keeping this issue around any longer. If we want to consider dropping support for later versions of Ruby we can always create a new issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@floehopper @nitishr