-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimization-pulltight45degree #302
Conversation
Freerouting uses too much memory is mainly because its searching queue has too many elements。 |
Thank you, now I will use your code to solve my routing. |
@L1uTongweiNewAccount Did you have the chance to test this modification? Does it work as you expected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you commented out a few lines. It would be preferable if you completely removed them. Could you do that before I accept this PR?
Stuck is mainly because the endless loop mentioned above. This PR is just a time saver for dense PCB. |
I couldn't do enough testing to justify the code removal, so I will close this PR for now. I don't disagree that it solves some problem for some people, I just can't verify if it breaks something for others. These kinds of modifications that impact the core algorithm would need rigorous testing, that I can't do at the moment without implementing automated testing with multiple inputs and their expected outputs. Nonetheless that your for your work, I hope to test it again at a later time when we have proper testing in place. |
This is an optimization for pulltight-45degree algorithm.
It can improve the performance when the PCB is very dense and the mode is under 45 °.