-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to cats 1.0.1 #136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 94.02% 94.49% +0.46%
==========================================
Files 23 23
Lines 469 472 +3
==========================================
+ Hits 441 446 +5
+ Misses 28 26 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -61,7 +62,7 @@ trait SchemaConversions { | |||
E.flatten { | |||
catchNonFatalAsSchemaError { | |||
val columnsM: M[List[Table.Column]] = | |||
E.traverse(metadata.getColumns.asScala.toList)(toTableColumn[M](_)(E)) | |||
Traverse[List].traverse(metadata.getColumns.asScala.toList)(toTableColumn(_))(E) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- Traverse[List].traverse(metadata.getColumns.asScala.toList)(toTableColumn(_))(E)
++ metadata.getColumns.asScala.toList.traverse(toTableColumn(_)(E))
@@ -18,6 +18,7 @@ package freestyle.cassandra | |||
package schema.provider.metadata | |||
|
|||
import cats.MonadError | |||
import cats.Traverse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With freestyle 0.5.1
Fixes #133