Frees Examples in Main Repo #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uses MonadError instead of fs2.util.Catchable * Uses cats.effect.Sync instead of fs2.util.Suspendable * Adds a README file explaining how to run and use the TodoList App * Other minor updates
fedefernandez
approved these changes
Oct 16, 2017
| import com.twitter.util._ | ||
| import com.zaxxer.hikari.{HikariConfig, HikariDataSource} | ||
| import doobie.hikari._, doobie.hikari.implicits._ | ||
| import doobie._, doobie.implicits._ |
There was a problem hiding this comment.
Maybe we could split these import statements into different lines, for consistency
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 85% 86.26% +1.26%
==========================================
Files 39 38 -1
Lines 300 284 -16
Branches 5 3 -2
==========================================
- Hits 255 245 -10
+ Misses 45 39 -6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
Particularly, the commits that are relevant to be reviewed are:
The rest of the code was mostly reviewed in its origin.