Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix placeholders in French translation #469

Closed
FlickTheManual opened this issue Feb 6, 2020 · 3 comments
Closed

Fix placeholders in French translation #469

FlickTheManual opened this issue Feb 6, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@FlickTheManual
Copy link

Hello,

great work for you application.

I got a little issue in front, I got a :user and :customer or :etat instead of the name of the actor or the customer.

image

didn't know where this come.

any help, pls? :)
@freescout-helpdesk
Copy link
Owner

French translation need to be fixed.
Placeholders like ':person' should not be translated, bu kept as is.

@freescout-helpdesk freescout-helpdesk added the help wanted Extra attention is needed label Feb 6, 2020
@freescout-helpdesk freescout-helpdesk changed the title field tag instead of field value for user, customers and state Fix placeholders in French translation Feb 6, 2020
@FlickTheManual
Copy link
Author

ho ok, my bad,
I make it in english, and we will see the user name as you say, thanks.

freescout-helpdesk added a commit that referenced this issue Feb 9, 2020
@freescout-helpdesk
Fix placeholders in French translations - closess #469
90a34c1
@fulldecent
Copy link
Contributor

This is now fixed, as per 90a34c1 . Recommending to close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fulldecent @FlickTheManual @freescout-helpdesk