RFC822 email attachements

[superduif]

Hi,

Would it be possible to just add the .eml extension to email attachments so that outlook or the default email application can open email attachments?

[fulldecent]

Which attachments should have the extension added?

[superduif]

The email rfc822 ones if they could have .eml extension then they would open in an email program without having to rename them... Thanks

…

On Fri, 09 Jul 2021, 18:39 William Entriken, ***@***.***> wrote: Which attachments should have the extension added? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#986 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5JSU7NTBORYHRCLEOD3ODTW4Q3HANCNFSM4V2ONSPA> .

[phanousk]

I add my appeal to this issue. Please don't strip the .eml extension.
Thank you, Petr

[superduif]

Hi, I edited a file on my free scout so that .eml is added when RFC822 files are downloaded... /var/www/html/app/Attachment.php I am pretty sure there is another way of doing it but I don't have the time go and find the right place to fix it so a simple if statement did the trick... Edited the following Function: public function download($view = false) { $headers = []; // #533 //return $this->getDisk()->download($this->getStorageFilePath(), \Str::ascii($this->file_name)); if ($view) { $headers['Content-Disposition'] = ''; } if ($this->file_name == "RFC822"){ $return1 = $this->getDisk()->download($this->getStorageFilePath(), $this->file_name.'.eml', $headers); } else { $return1 = $this->getDisk()->download($this->getStorageFilePath(), $this->file_name, $headers); } return $return1; }

…

On Thu, Oct 7, 2021 at 10:24 AM phanousk ***@***.***> wrote: I add my appeal to this issue. Please don't strip the .eml extension. Thank you, Petr — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#986 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5JSUZWZQ6AAHD3L226ACDUFVKKVANCNFSM4V2ONSPA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[superduif]

Hi,

This ticket was closed and resolved around a year ago it seems the response for RTF emails has been changed to undefined.

Could we not find a solution for the email attachment issue that does not rely on hardcoded instruction?

I have fixed the .eml attachment issue by amending the same statement as before just using "undefined" instead of "RFC822".

/**
 * Outputs the current Attachment as download
 */
public function download($view = false)
{
    $headers = [];
    // #533
    //return $this->getDisk()->download($this->getStorageFilePath(), \Str::ascii($this->file_name));
    if ($view) {
        $headers['Content-Disposition'] = '';
    }
    $file_name = $this->file_name;

    if ($file_name == "undefined"){
        $file_name = $file_name.'.eml';
    }

    return $this->getDisk()->download($this->getStorageFilePath(), $file_name, $headers);
}