audio: Improve performance and add error checks. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audio: Don't use slow insertion sort for sound list, just prepend instead. audio: Add error check after mallocs. audio: Simplify midi node comparison function.
|
I have nothing against. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
audio: Don't use slow insertion sort for sound list, just prepend instead.
audio: Add error check after mallocs.
audio: Simplify midi node comparison function.
I can see that for correct midi production the midi nodes need to be sorted by time, but I couldn't find any reason for keeping the sfx cache list sorted. @wdigger any reason for this?
It might be good to use a better data structure for this in the future but for now it is not that important since the midi production is only done once when the track is started, and there are not that many sounds.