fix Firefox doesn't load extra settings on restart #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Nov 4, 2022
| @@ -126,7 +126,7 @@ export async function executeScript({ | |||
| throw new Error('chrome.scripting does not support injecting strings of `code`'); | |||
| } | |||
|
|
|||
| void chrome.scripting.executeScript({ | |||
| void chromeP.scripting.executeScript({ | |||
There was a problem hiding this comment.
Hello, thanks for the PR, but this changes nothing on how code is executed. The only difference is maybe how an error is displayed in the console
Edit: chromeP is a polyfill for Chrome manifest v2 and it changes nothing in Firefox at all, both mv2 and mv3
There was a problem hiding this comment.
Thanks for the info and sorry for the trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue infokiller/web-search-navigator#450