merge upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added simpler "basic" example * Trying to make Quick Start the default contents "Philosophy" page is a bit too 'inside baseball' for an effective landing page. * Moved Philosophy down further * Added labels to 3rd party snippets * Minor formatting fix * fixing up quick start content * updating "quick start" content * a bit OCD formatting/alignment
* Added react-is to validate the proptype for Route's component. Removed a couple of outdated TODOs that dealt with __DEV__ The rest of the changes were done just from an npm install command React-is does add a tiny bit of size ( https://bundlephobia.com/result?p=react-is@16.5.2 ) as noted by the snapshots, but it seems like the best (and official) way to support the check. * Revert removal of __DEV__ * Updated the error message to be a little more clear about which prop is invalid. * Realized it wasn't saying what I wanted, so I just reverted it.
* Document generatePath function * Simplify some things
Also, smaller UMD builds.
* Test react-router(-dom) source, CJS, and UMD * Please go away, package-lock * Test against new CJS builds * Multi-test react-router-config * Remove "resolved by" comments * Retain original import order
* Update lockfiles and size snapshot * Replace invariant and warning with tiny versions * Replace invariant and warning with dev versions in react-router-dom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.