-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
falter-common: add /etc/profile.d/dynbanner.sh #61
Conversation
|
|
Just installed this on a normal OpenWrt-Snapshot Router? Is that wrong via opkg? |
No. That should work perfectly fine. Did you take the current code? I did some force-pushes within the last half our. |
|
After manualling executing the script i tlooks awesome! :D
|
d132873
to
6c3414e
Compare
Ich glaube der filename ist nicht so rictig: |
6c3414e
to
3a649e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having a dynamic banner is simply cool. But here are a few changes which may make this addition a bit better.
packages/falter-berlin-dynamic-banner/files/uci-defaults/add-banner-cron.sh
Outdated
Show resolved
Hide resolved
I just did a test. Whatever I execute in /etc/profile.d/dynbanner.sh is ran after the banner is printed. Here is my suggestion.
I think it would be a lot cleaner. It may not need to be it's own package anymore either. Maybe it would make more sense to go in falter-common. |
3a649e4
to
254237d
Compare
@pmelange Your suggestion is really neat indeed. At all events, we need to adjust |
Ah, okay, now I get your point. We don't need to patch
|
254237d
to
f8c3f58
Compare
b8bc128
to
6468a26
Compare
You are still calling rev.sh. |
No that is solved. :) |
one more small change request. Please use "uci -q get" instead of "uci get" |
Normally the directory /etc/profile.d does not exist. I don't know if it makes a difference, but you might have to update the Makefile. Could you please try installing this on a fresh system and check that it works? |
6468a26
to
e5c9d14
Compare
This gets built now. I can probably test this in one hour or so... |
At login time the script dynbanner.sh fetches some dynamic system information and prints it under the regular banner.
e5c9d14
to
3feb2e6
Compare
FYI. I took a look at the code in /etc/profile and saw the following:
And that is where the suggestion to change everything came from. |
How did the test go? |
The build failed due to a broken dependency on libcap. Probably, this isn't an issue of the change. I try to work around this. |
@pmelange I was able to build this. The
|
After wizard-run:
|
This package embeds regularily dynamic system information (i.e. system load,
uptime, amount of clients) into the banner. To protect the flash (limited amounts of writing cycles),
it uses tmpfs to store the new banner.