Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uhttpd defaults: set max_requests to 3 #183

Closed
wants to merge 1 commit into from
Closed

Conversation

pmelange
Copy link
Contributor

@pmelange pmelange commented Mar 2, 2019

Upstream, there has been a change to the default setting of uhttpd. The
new default does not allow concurrent cgi scripts to run. The result of this change can
be seen in issue freifunk-berlin/firmware#665

By setting max_requests to 3 (the previous value), the hasRootPass function no longer times out and the wizard runs as expected.

The upstream commit on openwrt/master is
openwrt/openwrt@c6aa9ff
The upstream commit on openwrt/18.06 is
openwrt/openwrt@e5a0b6c

This has been compiled locally and tested.

Upstream, there has been a change to the default setting of uhttpd.  The
new default does not allow concurrent cgi scripts to run.  The result can
be seen in issue #665

The upstream commit on openwrt/master is
openwrt/openwrt@c6aa9ff
The upstream commit on openwrt/18.06 is
openwrt/openwrt@e5a0b6c
@pmelange
Copy link
Contributor Author

I realize that there is currently an effort to fix the hasRootPass problem a different way (branch fix/issue665_cgi2rpc) but progress has stalled. I recommend using this fix until another solution is working.

@SvenRoederer
Copy link
Contributor

PR #186 it has been confirmed to work. Also upstream has reverted the change leading to the problem fixed here (f00a4ae6e0b1f7b3d84e11e8dc4dd562088584e0, e0505cc0182acf569cdd7b849189c134684160f8).

So I suggest to close this unmerged.

@pmelange pmelange closed this May 15, 2019
@pmelange pmelange deleted the uhttpd_defaults branch May 15, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants