OWM-script broken on Luci-master based builds

[torte71]

https://buildbot.berlin.freifunk.net/buildbot/unstable/ar71xx-generic/578/VERSION.txt
Firmware: git branch "SAm0815_experimental", revision f6104a8

Even though location settings are correctly entered in the wizard page (and made sure, the lat/lon values are not mixed up to meet some berlin friends in the arabian sea), the device doesn't get listed on https://openwifimap.net/
The device is running for over a day, so I think that should be enough time for an update?

[SvenRoederer]

What is the output when you run "owm.lua" from the command-line?

[torte71]

On Sun, 31 Dec 2017 04:47:03 -0800 Sven Roederer ***@***.***> wrote: What is the output when you run "owm.lua" from the command-line?

(run on a gl-ar150 - if that matters) /usr/bin/lua: ?:0: attempt to call field 'arptable' (a nil value) stack traceback: ?: in function 'get' /usr/sbin/owm.lua:74: in main chunk [C]: ?

[SvenRoederer]

seems like the LUCI-Api has changed again (see freifunk-berlin/firmware-packages#109 for something similar).
The current error causes the owm-script to fail to run and so there will be no upload to the server.

error comes from https://github.com/freifunk-berlin/firmware-packages/blob/master/utils/luci-app-owm/files/owm.lua#L74, which is very likely causes by
https://github.com/freifunk-berlin/firmware-packages/blob/master/utils/luci-app-owm/luasrc/owm.lua#L447 and following

[SvenRoederer]

sys.net.arptable() call in https://github.com/freifunk-berlin/firmware-packages/blob/master/utils/luci-app-owm/luasrc/owm.lua#L447 has changed.
Changing the line to

local arptable = {}

makes the code run, but without the values.

[ikreb7]

Hello @SvenRoederer ,

I have the same problem. Where do I exactly find this file at my router, please? Will this be fixed in a newer version soon?

[SvenRoederer]

@ikreb7 the file is located in /usr/lib/lua/luci as per https://github.com/freifunk-berlin/firmware-packages/blob/master/utils/luci-app-owm/Makefile#L98

[SvenRoederer]

Btw. do we really need the anonymized MAC-adresses in the public OWM-data?
What's their purpose?

[booo]

Some functions where dropped in the luci code base with this commit this openwrt/luci@366707a.

luci.sys.net.arptable() - replaced by luci.ip.neighbors()

Maybe it's enough to replace the function call?

[booo]

I merged a commit that should fix the problem.

We still have to update the feed for the berlin packages in the firmware.

[SvenRoederer]

still fails for me with

/usr/bin/lua: /usr/lib/lua/luci/owm.lua:447: attempt to index global 'luci' (a nil value)
stack traceback:
/usr/lib/lua/luci/owm.lua:447: in function 'get'
/usr/sbin/owm.lua:74: in main chunk
[C]: ?

[SvenRoederer]

/usr/bin/lua: /usr/lib/lua/luci/owm.lua:447: attempt to index global 'luci' (a nil value)

is fixed by freifunk-berlin/firmware-packages@c883485.

the code now fails with

/usr/bin/lua: /usr/lib/lua/luci/owm.lua:452: attempt to index field 'HW address' (a nil value)
stack traceback:
/usr/lib/lua/luci/owm.lua:452: in function 'get'
/usr/sbin/owm.lua:74: in main chunk
[C]: ?

[booo]

Sorry for the inconvenience. Seems like my testing procedure was flawed.

I will prepare a patch for the outstanding problems. We have to change the field names and convert them from userdata to string.

[booo]

As far as I can see we fixed this.