Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed BROKEN because sysupgrade works now #1613

Closed
wants to merge 1 commit into from
Closed

Removed BROKEN because sysupgrade works now #1613

wants to merge 1 commit into from

Conversation

mortzu
Copy link

@mortzu mortzu commented Jan 7, 2019

OpenWRT on Mikrotik supports sysupgrade now. Tested on mANTBox 15s (RB921GS-5HPacD-15S). I suggest removing BROKEN.

@rotanid rotanid added the 3. topic: hardware Topic: Hardware Support label Jan 7, 2019
@rubo77
Copy link
Contributor

rubo77 commented Jan 8, 2019

Please edit your commit message so it starts with "target mikrotic:"

@mweinelt
Copy link
Contributor

mweinelt commented Jan 8, 2019

ar71xx or ar71xx-mikrotik would be more appropriate as the prefix.

@Grotax Grotax mentioned this pull request Jan 13, 2019
@rotanid rotanid added the 5. needs: testing Testing of the changes is necessary label Jan 13, 2019
@rotanid
Copy link
Member

rotanid commented Jan 13, 2019

currently we have two device specifications in ar71xx-mikrotik.
marking this target as "unbroken" needs more than just some new information

Copy link
Contributor

@txt-file txt-file left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a different commit for that change. https://gitlab.com/txt.file/gluon/commit/97a01a1ddf9f2fcd9227276743a7e158ef5f8879

My idea is to use aliases as we are doing with the ubiquity devices (line 277 of ar71xx-generic). Mark tested devices as stable and untested devices as broken. Then we can check the device integration device by device.

I am currently compile-test my change as I am lacking the time to test it on my wAP ac.

@mweinelt
Copy link
Contributor

mweinelt commented Jan 16, 2019

I agree that creating model aliases and testing them by our usual checklist is a better solution than blindly removing the BROKEN mark on the generic image types. This would also improve the handling for firmware websites, that parse the filename to match them against enduser-compatible pretty names.

If we are in agreement I think you should create an alias for the model (mANTBox 15s), work through the checklist for your device, and add BROKEN conditions around all other generic images

@rotanid rotanid added the 2. status: rejected The proposal was considered but ultimately rejected label Jan 16, 2019
@rotanid
Copy link
Member

rotanid commented Jan 16, 2019

i agree with this, let's go on with very specific testing, e.g. in #1614

@rotanid rotanid closed this Jan 16, 2019
SvenRoederer added a commit to SvenRoederer/freifunk-gluon_core that referenced this pull request Sep 29, 2019
* update timezone-data

3d46f2593 timezone data: update to 2018c
ee319993e Merge pull request freifunk-gluon#1613 from user7887/lede-17.01
9eee806f9 i18n-ru: fixed and updated russian translation
43ab9c0a8 Merge pull request freifunk-gluon#1608 from user7887/lede-17.01
e58ce740d luci-app-travelmate fixed
f4d02b698 Merge pull request freifunk-gluon#1604 from user7887/lede-17.01
a016dbcee i18n-ru: fixed and updated russian translation
73abb7db5 Merge pull request freifunk-gluon#1590 from user7887/lede-17.01
b16253ed8 i18n-ru: fixed and updated russian translation
f8682164c Fix bad argument #1 to 'tonumber'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: rejected The proposal was considered but ultimately rejected 3. topic: hardware Topic: Hardware Support 5. needs: testing Testing of the changes is necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants