New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed BROKEN because sysupgrade works now #1613
Conversation
Please edit your commit message so it starts with "target mikrotic:" |
|
currently we have two device specifications in ar71xx-mikrotik.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote a different commit for that change. https://gitlab.com/txt.file/gluon/commit/97a01a1ddf9f2fcd9227276743a7e158ef5f8879
My idea is to use aliases as we are doing with the ubiquity devices (line 277 of ar71xx-generic). Mark tested devices as stable and untested devices as broken. Then we can check the device integration device by device.
I am currently compile-test my change as I am lacking the time to test it on my wAP ac.
I agree that creating model aliases and testing them by our usual checklist is a better solution than blindly removing the BROKEN mark on the generic image types. This would also improve the handling for firmware websites, that parse the filename to match them against enduser-compatible pretty names. If we are in agreement I think you should create an alias for the model ( |
i agree with this, let's go on with very specific testing, e.g. in #1614 |
* update timezone-data 3d46f2593 timezone data: update to 2018c ee319993e Merge pull request freifunk-gluon#1613 from user7887/lede-17.01 9eee806f9 i18n-ru: fixed and updated russian translation 43ab9c0a8 Merge pull request freifunk-gluon#1608 from user7887/lede-17.01 e58ce740d luci-app-travelmate fixed f4d02b698 Merge pull request freifunk-gluon#1604 from user7887/lede-17.01 a016dbcee i18n-ru: fixed and updated russian translation 73abb7db5 Merge pull request freifunk-gluon#1590 from user7887/lede-17.01 b16253ed8 i18n-ru: fixed and updated russian translation f8682164c Fix bad argument #1 to 'tonumber'
OpenWRT on Mikrotik supports sysupgrade now. Tested on mANTBox 15s (RB921GS-5HPacD-15S). I suggest removing BROKEN.