gluon-mesh-batman-adv: reenable batman-adv multicast optimizations #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With batman-adv 2020.4 and the according backports to batman-adv v2019.2 several more bugs were found and fixed regarding the batman-adv multicast optimizations feature. Also a "wakeup-call" feature was added to the Linux bridge IGMP/MLD snooping code in Gluon to work around issues with Android devices. With batman-adv now at v2019.2, multicast-to-multi-unicasts conversion is supported, too. Which means that even if there are a few outdated nodes these and all other recipients will be served multicast packets via unicast, too, as long as the sum of receiving nodes does not exceed the multicast fanout setting (default: 16). If is exceeded, then batman-adv will revert back to broadcast flooding automatically. Long story short, with all these extra measures in place, let's reenable the batman-adv multicast optimizations to reduce the layer 2 overhead and in preparation for multicast applications in the future. The default is enabled for this feature anyway, so removing the "batctl multicast_mode 0" overwrite is sufficient. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
mweinelt
added
3. topic: batman-adv
0. type: enhancement
This was referenced May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With batman-adv 2020.4 and the according backports to batman-adv v2019.2
several more bugs were found and fixed regarding the batman-adv
multicast optimizations feature.
Also a "wakeup-call" feature was added to the Linux bridge IGMP/MLD
snooping code in Gluon to work around issues with Android devices.
With batman-adv now at v2019.2, multicast-to-multi-unicasts conversion
is supported, too. Which means that even if there are a few outdated nodes
these and all other recipients will be served multicast packets via unicast,
too, as long as the sum of receiving nodes does not exceed the multicast
fanout setting (default: 16). If is exceeded, then batman-adv will revert
back to broadcast flooding automatically.
Long story short, with all these extra measures in place, let's reenable
the batman-adv multicast optimizations to reduce the layer 2 overhead
and in preparation for multicast applications in the future.
The default is enabled for this feature anyway, so removing the
"batctl multicast_mode 0" overwrite is sufficient.
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>