mkbgp: Optionally set unreachable peers as passive #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By passing -P <timeout>, the script now checks if the BGP peer is reachable by opening a TCP connection to the BGP port. If it isn't, it is added to the config nonetheless but only as passive peer, meaning that incoming connections from this peer will be accepted but no attempts to establish a connection is made. NOTE: Only bird supports the passive peer feature, so only bird is supported by this new option. While supplying -P together with "-f quagga" isn't an error and will still do the checking, it doesn't change the resulting config in any way.
jplitza
force-pushed
the
feature-passive-offline
branch
from
223a3bd
to
9838ae9
Compare
|
ACK |
|
Just noticed that the readme needed an update because of the changed help message. So… I haven't followed this repo closely lately, but how many ACKs does a PR need? 😃 |
|
I don't know. I can't remember getting more than 2 |
jplitza
added a commit
that referenced
this pull request
Dec 21, 2015
mkbgp: Optionally set unreachable peers as passive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing -P , the script now checks if the BGP peer is reachable by opening a TCP connection to the BGP port. If it isn't, it is added to the config nonetheless but only as passive peer, meaning that incoming connections from this peer will be accepted but no attempts to establish a connection is made.
NOTE: Only bird supports the passive peer feature, so only bird is supported by this new option. While supplying -P together with "-f quagga" isn't an error and will still do the checking, it doesn't change the resulting config in any way.