Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feil: Bruk av NavTabs viser ikke underline for aktiv tab #3863

Closed
Tvedt1 opened this issue Apr 17, 2024 · 1 comment · Fixed by #3865
Closed

Feil: Bruk av NavTabs viser ikke underline for aktiv tab #3863

Tvedt1 opened this issue Apr 17, 2024 · 1 comment · Fixed by #3865
Assignees
@ivarni
Labels
🐝 bug Noe er feil eller ikke som det skal

Comments

@Tvedt1
Copy link

Tvedt1 commented Apr 17, 2024

Vi skal bruke NavTabs i Flyt. Aktiv tab aktiveres av aria-selected. Det gir bold tekst på aktiv tab men ikke underline slik det gjør hvis vi bruker Tabs og TabList.

Med NavTabs
MicrosoftTeams-image (1)
MicrosoftTeams-image (2)

Med Tabs og TabList
MicrosoftTeams-image (3)
MicrosoftTeams-image (4)

Forventet oppførsel

At det skal være underline ved bruke av både NavTabs og Tabs, TabList
@Tvedt1 Tvedt1 added the 🐝 bug Noe er feil eller ikke som det skal label Apr 17, 2024
@ivarni ivarni self-assigned this Apr 22, 2024
@ivarni
Copy link
Contributor

ivarni commented Apr 22, 2024

@Tvedt1 Jeg ser at komponenten ikke er så god til å håndtere URLer med hash-fragmenter (faktisk prøver den ikke engang) og bare ser på location.path når den skal regne ut hvor underline befinner seg. Tenker det er noe vi også burde håndtere så finner en fiks på dette i løpet av uka.

ivarni added a commit that referenced this issue Apr 22, 2024
@ivarni
fix: navTabs uses aria-selected to find active tab
6d54bdb 
Previously the NavTabs component only considered location.path which does not work with hash URLs

BREAKING CHANGE:
If you are not providing aria-selected to the active tab, either because you silenced the TS warning
or are not using TS the active component will no longer be visually indicated

ISSUES CLOSED: #3863
ivarni added a commit that referenced this issue Apr 22, 2024
@ivarni
fix: navTabs uses aria-selected to find active tab
a5dabaa 
Previously the NavTabs component only considered location.path which does not work with hash URLs

BREAKING CHANGE:
If you are not providing aria-selected to the active tab, either because you silenced the TS warning
or are not using TS the active component will no longer have an underline

ISSUES CLOSED: #3863
@ivarni ivarni mentioned this issue Apr 22, 2024
Merged
2 tasks
ivarni added a commit that referenced this issue Apr 22, 2024
@ivarni
fix: navTabs uses aria-selected to find active tab
c894d59 
Previously the NavTabs component only considered location.path which does not work with hash URLs

BREAKING CHANGE:
If you are not providing aria-selected to the active tab, either because you silenced the TS warning
or are not using TS the active component will no longer have an underline

ISSUES CLOSED: #3863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivarni ivarni

Labels
🐝 bug Noe er feil eller ikke som det skal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: navTabs uses aria-selected to find active tab fremtind/jokul
2 participants
@ivarni @Tvedt1