Legg til ref forwarding i Select #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piofinn
requested review from
Saegrov,
gbrownlee,
joms,
lfbergee,
SercanSercan and
vegardsoerlie
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 517c66c:
|
piofinn
force-pushed
the
feat/select-ref
branch
from
9b472e8
to
128c4f4
Compare
affects: @fremtind/jkl-select-react Adds ref forwarding to the Select component using a hidden native select element reflecting the value of the field BREAKING CHANGE: Added forwardRef, which may break behaviour
piofinn
force-pushed
the
feat/select-ref
branch
from
128c4f4
to
886ea59
Compare
lfbergee
approved these changes
Dec 9, 2020
vegardsoerlie
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Proposed changes
Siden flere team nå bruker
react-hook-former det ønskelig å kunne brukereffor å registrere skjemafelter. Selv om man kan bruke custom komponenter ved hjelp avControllermister man noe funksjonalitet, som for eksempel å kunne fokusere på feltet ved feil i skjemaet.Denne PRen legger til støtte for dette i Select, ved å legge til et skjult
<select>-element som speiler valgt verdi, og som dytter fokus videre til vårt custom element. Det blir dermed mulig å bruke feltet medref={register()}ireact-hook-form.name-attributten i både Select og NativeSelectforwardRef☑️ Submission checklist
yarn buildworks locally with my changes💬 Further comments
Jeg har ikke klart å finne noen bakdeler ved denne tilnærmingen med tanke på ting som UU eller generell brukeropplevelse; implementasjonen virker helt transparent. Men jeg tipper det finnes edge-cases som jeg ikke har tenkt på. Setter pris på om noen legger hodet i bløt på denne 😊
Skal få laget en liten sandbox med
react-hook-formila dagen så det blir enklere å teste endringene.