Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatters-util): bedre typing av options til register with mask #2929

Merged
merged 1 commit into from Jun 28, 2022

Conversation

henrikhermansen
Copy link
Contributor

Typingen av options til register-funksjonene fra registerWithMasks var litt upresis. Her var RegisterOptions<T> fra react-hook-form brukt direkte, men det blir ikke riktig at setValueAs er med her. Dersom konsumenten sender med en verdi her, blir den ignorert. Da er det bedre å fjerne den fra typen.

🎯 Sjekkliste

@fremtind-bot
Copy link
Collaborator

fremtind-bot commented Jun 23, 2022

Forhåndsvisning: https://jokul.fremtind.no/preview/fix-register-with-mask-type
🔍 Commit: 0b2eb02

Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes.

fremtind-bot added a commit that referenced this pull request Jun 23, 2022
@henrikhermansen henrikhermansen merged commit 3981302 into main Jun 28, 2022
@henrikhermansen henrikhermansen deleted the fix-register-with-mask-type branch June 28, 2022 12:14
github-actions bot pushed a commit that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants