Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added hasNoIllegalCharacters validator #3206

Merged
merged 1 commit into from Oct 24, 2022
Merged

Conversation

kennidenni
Copy link
Contributor

@kennidenni kennidenni commented Oct 21, 2022

Usikker på om dette var ønskelig i Jøkul, men vi bruker denne i hele kundeklienten og tenkte kanskje andre også ville ha bruk for den.

🎯 Sjekkliste

@kennidenni kennidenni self-assigned this Oct 21, 2022
@fremtind-bot
Copy link
Collaborator

fremtind-bot commented Oct 21, 2022

Forhåndsvisning: https://jokul.fremtind.no/preview/illegal-chars-validator/
🔍 Commit: f328168

Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes.

fremtind-bot added a commit that referenced this pull request Oct 21, 2022
Copy link
Contributor

@wkillerud wkillerud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser det blandes mellom hasNoIllegalValues og hasNoIllegalCharacters i kode, filnavn og dokumentasjon. Fint om det bare er det ene eller det andre.

@kennidenni
Copy link
Contributor Author

Ser det blandes mellom hasNoIllegalValues og hasNoIllegalCharacters i kode, filnavn og dokumentasjon. Fint om det bare er det ene eller det andre.

Oi, vet ikke helt hva jeg holdt på med når jeg skrev det der, men det er fikset nå!

fremtind-bot added a commit that referenced this pull request Oct 21, 2022
fremtind-bot added a commit that referenced this pull request Oct 21, 2022
@wkillerud wkillerud merged commit 83025d8 into main Oct 24, 2022
@wkillerud wkillerud deleted the illegal-chars-validator branch October 24, 2022 07:11
github-actions bot pushed a commit that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants