chore: fiks linkerscriptet for pnpm #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSUES CLOSED: #3309
wkillerud
added
the
👷♂️ CI & infra
wkillerud
commented
Dec 8, 2022
| description: "Hva er filstien til prosjektet hvor du vil teste?", | ||
| message: "Kan være absolutt (starte med /) eller relativ (starte med ../).", | ||
| required: true, | ||
| let projectPath = process.argv[2]; |
There was a problem hiding this comment.
Åpner for pnpm linker ../path/to/project uten et prompt.
|
✅ Forhåndsvisning: https://jokul.fremtind.no/preview/fix/pnpm-linker/ Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -81,7 +94,11 @@ | |||
| continue; | |||
| } | |||
|
|
|||
| execSync(`${tool} link`, { cwd: path.join(__dirname, "..", "packages", entry.name), windowsHide: true }); | |||
| if (isPnpm) { | |||
| execSync(`pnpm link ${packagePath}`, { cwd: resolvedPath, windowsHide: true }); | |||
Check warning
Code scanning / CodeQL
Shell command built from environment values
fremtind-bot
added a commit
that referenced
this pull request
Dec 8, 2022
piofinn
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #3309
🎯 Sjekkliste
pnpm buildogpnpm ci:testgir ingen feil