-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove derp section from ClientConnectivity model #428
Conversation
@frenck , I don't seem to be able to resolve the issue with the labels myself. Any assistance appreciated. |
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 91.07% 90.99% -0.09%
==========================================
Files 4 4
Lines 112 111 -1
Branches 15 15
==========================================
- Hits 102 101 -1
Misses 9 9
Partials 1 1
|
Sorry for the mess in the changes above. I messed up the merge :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @heretic098 👍
../Frenck
Proposed Changes
Remove the requirement for the tailscale API to return the derp information in the ClientConnectivity section of the response as it has been removed in tailscale/tailscale@b7988b3.
Create a default empty list to hold tags in case none are returned from the API. This avoids issues returning information where some devices have no tags defined. In this case with the current implementation you see errors like this:
Related Issues
#427