Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace python-tailscale dependency with a fork #103395

Closed
wants to merge 1 commit into from

Conversation

offbyone
Copy link

@offbyone offbyone commented Nov 4, 2023

Proposed change

I have forked python-tailscale in order to fix #102111

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Context: I have forked the python tailscale library due to ongoing maintainer neglect, both of that library and of other libraries that I've been using.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @offbyone

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Nov 4, 2023

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (tailscale) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tailscale can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tailscale Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck
Copy link
Member

frenck commented Nov 4, 2023

Let's fix the upstream library used instead.

Context: I have forked the python tailscale library due to ongoing maintainer neglect, both of that library and of other libraries that I've been using.

Would be nice if you'd reached out. (which is btw a requirement in case you want to replace a library).

../Frenck

@frenck frenck closed this Nov 4, 2023
@offbyone offbyone deleted the fork-tailscale-lib branch November 4, 2023 19:08
@offbyone
Copy link
Author

offbyone commented Nov 4, 2023

I have had a PR open against a repo you maintain for over a year without even getting ci approved to run. I'm sorry for not reaching out again, but my only communication with you previously has been dismissing stalebot notifications that my PR will be closed.

@frenck
Copy link
Member

frenck commented Nov 4, 2023

The upstream PR is here: frenck/python-tailscale#428

And is fairly young?

../Frenck

@frenck
Copy link
Member

frenck commented Nov 4, 2023

I have had a PR open against a repo you maintain for over a year without even getting ci approved to run.

This bug doesn't exist for that time? I'm confused.

../Frenck

@frenck
Copy link
Member

frenck commented Nov 4, 2023

I'll reserve some time tomorrow to bump the lib source.

There is a bigger issue that needs addressing (which is mostly the reason for not having progressed on it lately).

../Frenck

@offbyone
Copy link
Author

offbyone commented Nov 4, 2023

The PR in question is in another repo. Anyway, with this one underway I'm 100% happy not to need a fork in order to get my ha system working again. Thank you, and if the bigger issues you mention can use another pair of eyes I'm happy to help.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailscale Error
2 participants