-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace python-tailscale dependency with a fork #103395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Let's fix the upstream library used instead.
Would be nice if you'd reached out. (which is btw a requirement in case you want to replace a library). ../Frenck |
I have had a PR open against a repo you maintain for over a year without even getting ci approved to run. I'm sorry for not reaching out again, but my only communication with you previously has been dismissing stalebot notifications that my PR will be closed. |
The upstream PR is here: frenck/python-tailscale#428 And is fairly young? ../Frenck |
This bug doesn't exist for that time? I'm confused. ../Frenck |
I'll reserve some time tomorrow to bump the lib source. There is a bigger issue that needs addressing (which is mostly the reason for not having progressed on it lately). ../Frenck |
The PR in question is in another repo. Anyway, with this one underway I'm 100% happy not to need a fork in order to get my ha system working again. Thank you, and if the bigger issues you mention can use another pair of eyes I'm happy to help. |
Proposed change
I have forked python-tailscale in order to fix #102111
Type of change
Additional information
Context: I have forked the python tailscale library due to ongoing maintainer neglect, both of that library and of other libraries that I've been using.
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: