Improve Message.to_string for OpenFlow0x01 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #79
A Hello message may contain an uninterpreted body. Provide some indication if it does or not. Related to #79
These messages may contain an uninterpreted body, so provide some indication of whether or not they do. Related to #79.
Many of the messages had to_string functions that simply weren't being called, one exception being VendorMsg. Related to #79.
The two are redundant. Related to #79.
... when possible. Related to #79.
|
LGTM |
mcanini
pushed a commit
that referenced
this pull request
Feb 27, 2014
Improve Message.to_string for OpenFlow0x01
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79.
For now, punting on OpenFlow0x04.