RoundTrip testing Using QuickCheck #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just missing a 'C'.
Somebody else should look at this commit. Because of they way that the parse and marshal (i.e., make) functions work for PseudoPort, the code manually tracks parameter of the Controller constructor in the serialization datatype. This test therefore does not check whether or not the artibrary instance generates valid data for that parameter.
Use OpenFlow0x01_ArbitraryCstruct when a data structure can be serialized to a Cstruct.t and exposes a to_string function on its type. Use the functor OpenFlow0x01_Unsize to transform the module into one of type OpenFlow0x01_Arbitrary.
These are reusable arbitrary instances. They should likely live somewhere outside of the Match QuickCheck module, but for now they're fine there.
The controller parameter should be an unsigned int. It was not previously exercised by the PseudoPort roundtrip test, but will be exercised in subsequent commits.
These are all the functions that are necessary to creat an OpenFlow0x01_ArbitraryCstruct module.
to_int and of_info for marshal and parse, respectively.
to_int and of_info for marshal and parse, respectively.
Certain functions on in the OpenFlow0x01 API expect a pseudoPort but do not handle the Controller variant properly. At some point the code should discriminate on the different input domains at the type level, but until then use this function to test. With this commit the Enqueue case of the Action roundtrip test now works, which was introduced but commented out in fa51a3f. Related to #5.
These are all the functions that are necessary to creat an OpenFlow0x01_ArbitraryCstruct module.
The out_port was always assumed to be either absent or to be representing a physical port. The PseudoPort.make functions was simply not being called.
jnfoster
added a commit
that referenced
this pull request
Oct 15, 2013
RoundTrip testing Using QuickCheck
|
Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement roundtrip testing using QuickCheck for the following modules:
This pull request had to modify all their public APIs to expose the
marshalandparsefunctions—though they're sometimes called something else—as well as any other necessary functions to perform roundtrip testing. This pull request also introduces several interfaces that are useful for setting up these tests:OpenFlow0x01_Arbitrary: requires amarshal,parse, andto_stringfunction on the data type, and you also must specify the serialization type for the types to work out.OpenFlow0x01_ArbitraryCstruct: assumes the serialized type is aCstruct, and therefore also requires asize_offunction; andOpenFlow0x01_Unsize: a functor to convert the latter module to the former.I only found one bug throughout testing, which I fixed in 092b7fd.