This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Fix crash when a manifest was evicted but the object is in the cache #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally, it is crashing! |
|
Indeed, removing a manifest will not remove all referenced artifacts (because those artifacts are still usable if you don't use the 'direct' mode at all). So it may be that when adding an entry in direct mode, a manifest is missing but the referenced artifact is already there. I'm curious to see whether the patch I mentioned in #236 (comment) makes the test pass. |
…e cache before trying to write it
Current coverage is 88.86% (diff: 100%)@@ master #237 diff @@
==========================================
Files 1 1
Lines 997 997
Methods 0 0
Messages 0 0
Branches 158 158
==========================================
Hits 886 886
Misses 83 83
Partials 28 28
|
siu
changed the title
|
Yes, it fixes it, all tests are passing. |
|
Great job, I think this resolves #155 after all! |
|
@frerich I think you closed the issue instead of merging it. |
|
Ooops @siu, sorry! I seem to have hit the wrong button - that was not intentional. Thanks for catching! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests that check if the evicted objects and manifests are handled properly, attempt to reproduce #155.