Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve a rare problem where keyboard height will be full-screen on dismissal #39

Merged
merged 1 commit into from Jan 17, 2022

Conversation

stuartcamerondeakin
Copy link
Contributor

A couple of users have reported issues where when dismissing the on-screen keyboard the top of the keyboardLayoutGuide would float to the top of the screen. This works around that issue by explicitly handling the keyboardWillHideNotification.

@Jon889
Copy link

Jon889 commented Jan 12, 2022

I've found the same thing, this happens specifically when Reduce Motion is turned on in accessibility settings.

@s4cha any chance this could be merged and released?

@s4cha
Copy link
Member

s4cha commented Jan 17, 2022

@stuartcamerondeakin Thanks a ton for your contribution! Never ran into this bug before but code looks good to me.
PS: Please excuse the eternity it took me to finally review this 😄

@s4cha s4cha merged commit af93672 into freshOS:master Jan 17, 2022
@s4cha
Copy link
Member

s4cha commented Jan 20, 2022

This is now up in https://github.com/freshOS/KeyboardLayoutGuide/releases/tag/1.8.0, Thanks !!

AlexSeverinov pushed a commit to AlexSeverinov/KeyboardLayoutGuide that referenced this pull request Nov 15, 2023
Solve a rare problem where keyboard height will be full-screen on dismissal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants