Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Introduces standalone SMTP transport usage #9

Merged
merged 4 commits into from
Jan 3, 2020
Merged

Introduces standalone SMTP transport usage #9

merged 4 commits into from
Jan 3, 2020

Conversation

jvandesande
Copy link

No description provided.

Copy link
Author

@jvandesande jvandesande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/DependencyInjection/FHMailerExtension.php Outdated Show resolved Hide resolved
support/docs/configuration.md Outdated Show resolved Hide resolved
{
$stream = new SocketStream();
$stream->disableTls();
$stream->setPort($dsn->getPort(25));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik neem aan dat die 25 de default is die je wilt gebruiken en als je zelf een andere specificeert in je DSN dat die dan gebruikt wordt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dat neem ik ook aan. Moeten we testen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getest en dat klopt

@mishaklomp mishaklomp marked this pull request as ready for review January 3, 2020 12:12
@jvandesande jvandesande merged commit 240952a into develop Jan 3, 2020
@mishaklomp mishaklomp deleted the notls branch January 3, 2020 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants