Add option to load .cjs config file

[revmischa]

Ref: #73 (comment)

Since it's too much work to change the setup step to be async to do a dynamic import(), we can just specify our config to be CJS and not try to import ESM config in an ESM project.

[freshollie]

Nice. Thanks for this!

If you feel like it, would be good to add a integration test for this:

• Make a new config under the tests directory
• Use an advanced setup to point the test towards a new config directory where you.cjs config is located

[revmischa]

Ok I added a test
BTW I'm trying out this module using vitest and it works pretty fine. Maybe it should just be renamed to "test-dynalite" since it's not really jest-specific.

[freshollie]

Maybe it should just be renamed to "test-dynalite" since it's not really jest-specific

hmm, main reason is because it's designed specifically for jest. I wonder if there could be entry points just for jest: test-dynalite/jest 🤔

[freshollie]

You should probably name this .cjs to actually test the CJS feature?

[revmischa]

Ok
I don't really understand how the tests are being run
Eslint is yelling at me:

Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: tests/configs/cjs/jest-dynalite-config.cjs.
The file must be included in at least one of the projects provided.

I couldn't find what to change to make it happy

[freshollie]

You need to add "*.cjs" to the tsconfig.esllint.json at the root of the repo. Atm I think it only includes .js and .ts

[freshollie]

I don't really understand how the tests are being run
If you run yarn test you will see, they are effectively integration tests which ensure dynalite functions with an actual jest setup rather than unit.

The idea here is we want to ensure that .cjs configs do actually work and don't regress

[coveralls]

Pull Request Test Coverage Report for Build 2416645686

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.04%) to 88.667%

---

Totals
Change from base Build 2240650438:	0.04%
Covered Lines:	196
Relevant Lines:	210

---

💛 - Coveralls

[freshollie]

Thanks!

[revmischa]

Thank you! Any chance you could do a release please? 🙏🏻

[freshollie]

Apologies, pushed this as v3.6.0 now should go live soon

[revmischa]

Thanks a lot!