Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

globbed directory with --ref seems to not work #137

Open
ajsalminen opened this issue Feb 24, 2016 · 3 comments
Open

globbed directory with --ref seems to not work #137

ajsalminen opened this issue Feb 24, 2016 · 3 comments

Comments

@ajsalminen
Copy link

Seems like I've encountered a bug when trying to do this:
fresh DanielVartanov/willgit bin/\* --ref=f5403069d33dc0887267278080d74c2e6a197441 --bin

When running fresh, it errors out with "fatal: Path 'bin/.fresh-order' does not exist in 'f5403069d33dc0887267278080d74c2e6a197441'".

Removing the --ref argument makes it work.
@ajsalminen
Copy link
Author

Reading the documentation now and testing something similar it seems like this shouldn't have worked with or without the --ref anyway so I'm closing and opening a feature enhancement issue instead.

@jasoncodes
Copy link
Member

The error message you received regarding .fresh-order when combining globs, --ref, and --file/--bin together sounds like a legitimate bug to me. I’m going to re-open this issue. Thanks for reporting it.

@jasoncodes jasoncodes reopened this Sep 28, 2017
@star-szr
Copy link

Ran into this today, does seem like a legitimate bug and no --file or --bin needed to reproduce, just a glob and ref.

This doesn't work, based on a README example:
fresh jasoncodes/dotfiles shell/aliases/\* --ref=fda225f

fatal: Path 'shell/aliases/.fresh-order' does not exist in 'fda225f'

smstern added a commit to smstern/fresh that referenced this issue May 28, 2020
@smstern
Check .fresh-order file before call 'git show'
aaf1d20 
git show returns with exit code 128, in case of non-existing file.

This change checks if the .fresh-order is part of the directory
and only if the file is present the git show command will be invoked.

Issue: freshshell#137
@smstern smstern mentioned this issue May 28, 2020
Merged
@jasoncodes jasoncodes mentioned this issue May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --ref globbing when no .fresh-order exists freshshell/fresh
3 participants
@jasoncodes @star-szr @ajsalminen