Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Creation of New Users to UserAdministration #1

Merged
merged 5 commits into from
Jun 14, 2011

Conversation

JamesKovacs
Copy link

Subject line says it all. :)

James

@fretje
Copy link
Owner

fretje commented May 28, 2011

Very nice work! A minor remark though. Shouldn't we ask a confirm password on the Create User view, to catch typo's?
Also: this is probably due to how the default .net membership provider works, but the user that has been created seems to be "online", although he didn't log on yet.

fretje added a commit that referenced this pull request Jun 14, 2011
Added Creation of New Users to UserAdministration
@fretje fretje merged commit f96ec63 into fretje:master Jun 14, 2011
@JamesKovacs
Copy link
Author

Thanks for merging my pull request. I didn't have time to make the suggested changes, though they're good ones. I had done the work to satisfy a client's requirements and the client agreed to contribute the changes back to the original project. So thank you for the project as it saved me a bunch of time writing all this by hand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants