-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema included in a data package not added to CKAN #61
Comments
Suppose we could import/export schema from/to datapackage.json to/from CKAN. Like that idea. I wonder though, how that relates to the field information provided bij de datastore-create-API and the datapusher-extension. For example, the test for the API provided in the CKAN documentation gives this result:
Will this be compatible? |
@GeraldGrootRoessink this is related and worth a read ckan/ckanext-validation#1 |
Worth a read indeed. My understanding is that ckanext-validation introduces with ckanext-scheming a new field schema that accepts a json-object like (without the whitespace): Am I right? |
Me again.
This works |
@GeraldGrootRoessink That sounds like a good approach, can you submit a PR? |
Submitted a PR. However the coverall/coverage checks fails at 96.465 because of a warning: tests/test_converter.py::TestDataPackageToDatasetDict::test_datapackage_name_title_and_version I'm afraid I'm in over my head with this one. |
@GeraldGrootRoessink this is coverage complaining that you didn't add a test for your change :) I did myself here, plus fixed the logic for the inverse path (dataset -> datapackage). |
Super. For anyone who follows: It will only work nicely if there is a schema-field defined as a json-object. For example I managed this using https://github.com/ckan/ckanext-scheming. |
A data package can include schemas for each data resource. When I upload a datapackage.zip file containing schemas I expect these to be stored in CKAN.
If they were stored they could be
The text was updated successfully, but these errors were encountered: