Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from QGOV fork #57

Closed

Conversation

ThrawnCA
Copy link
Contributor

Overview

  • Don't validate the entire package when updating a single resource
  • Add config for running tests in Docker containers
  • Improve flake8 compatibility
  • Use parameterised logging to reduce unnecessary string concatenation
  • Prepare for Python 3; use six for compatible string types, fix exception handling syntax

Please preserve this line to notify @amercader (lead of this repository)

antuarc and others added 27 commits March 4, 2020 16:20
- Less comprehensive than the existing nosetests, but they haven't worked for a long time
[QOL-6510] don't validate all resources in a package if it was origin…
[QOL-6510] test against example.com to avoid WAF problems
- use parameterised logging instead of formatting up-front
- use 'six' for Python 3 compatibility
[QOL-6491] enable file downloads to go through a proxy if needed
- Thanks to Goodtables/Frictionless maintainers for pointing out how to do this
[QOL-6491] provide proxy config directly to 'validate' function
@amercader
Copy link
Member

amercader commented Jul 28, 2022

@ThrawnCA I'd love to get these ported to the latest 1.0.0 version, can you submit a fresh PR? thanks

  • Don't validate the entire package when updating a single resource
  • Use parameterised logging to reduce unnecessary string concatenation

@amercader amercader closed this Jul 28, 2022
amercader added a commit that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants