Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Profile loading from cache #108

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Fix Profile loading from cache #108

merged 1 commit into from
Mar 25, 2019

Conversation

joemirizio
Copy link
Contributor

Fixes a bug when loading a Profile from the cache. It currently throws the following error:

DataPackageError: Profiles registry hasn't profile "http://example.com/data-package.json"

@roll roll added this to Software in Frictionless General Mar 19, 2019
@roll roll moved this from Software to In progress in Frictionless General Mar 19, 2019
@rufuspollock
Copy link
Contributor

@roll could you review this do you think?

@roll
Copy link
Member

roll commented Mar 21, 2019

@joemirizio
@rufuspollock
Thanks, will review in a few days

@roll roll moved this from Pull Requests to Software in Frictionless General Mar 25, 2019
roll
roll approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@roll roll merged commit 8346c2c into frictionlessdata:master Mar 25, 2019
Frictionless General automation moved this from Software to Done Mar 25, 2019
@roll roll removed the {review} label Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roll roll roll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Frictionless General
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joemirizio @rufuspollock @roll @akariv