Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self -> this :( #68

Merged
merged 1 commit into from
Apr 7, 2017
Merged

self -> this :( #68

merged 1 commit into from
Apr 7, 2017

Conversation

akariv
Copy link
Member

@akariv akariv commented Apr 6, 2017 •
edited

apologies 馃樁

@akariv akariv added the review label Apr 6, 2017
@akariv akariv requested a review from roll April 6, 2017 18:50
roll
roll approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@roll roll left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There is a self usage in this class so I suppose there is a reason on confusion. Also missed it.

@roll roll merged commit 599b31a into master Apr 7, 2017
@roll roll deleted the fix/too-much-python branch April 7, 2017 08:02
@roll roll removed the review label Apr 7, 2017
@roll roll self-assigned this Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roll roll roll approved these changes

Assignees

@roll roll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akariv @roll