Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded library to work with specs-v1 #76

Merged
merged 13 commits into from
Apr 18, 2017
Merged

Upgraded library to work with specs-v1 #76

merged 13 commits into from
Apr 18, 2017

Conversation

roll
Copy link
Member

@roll roll commented Apr 18, 2017


@amercader
please take a look

Because of brithis holidays I've decided to put all changes into one PR to not be blocked. So there are many changes. I suppose the easiest way to review will be going commit by commit. Describing main steps:

  • added specs-v1 jsonschemas using starndard to the stack way with up-to-date tests - 93dfd6f
  • merged node/browser tests into one codebase because it was splited into two mostly identical copies making changing the actual codebase really difficult - 3696312
  • introduced Profile class based on Python API - e5162ba
  • updated Resource class based on Python implementation - b7d68a2
  • update DataPackage class based on Python implementation - aa4b3a9

I would say the codebase state before this PR was more like a prototype so I've just ported many things from Python codebase. It was easier than twaeking existent ones. Especially it's related to tests - we had a really small amount of them. So now it's covered much better and also it uses many Python test cases so we aim here cross-language consistency in behaviour.

During this work I've tweaked API based on previosly raised issues and improved readme - https://github.com/frictionlessdata/datapackage-js/tree/specs-v1#datapackage-js (could be a good review start).

That the last PR for core libs to specs-v1 update.

@roll roll requested a review from amercader April 18, 2017 07:43
@roll roll added the review label Apr 18, 2017
Copy link
Member

@amercader amercader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good @roll 👍

@roll
Copy link
Member Author

roll commented Apr 18, 2017

@amercader
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment