-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded library to work with specs-v1 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amercader
approved these changes
Apr 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good @roll 👍
@amercader |
This was referenced Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amercader
please take a look
Because of brithis holidays I've decided to put all changes into one PR to not be blocked. So there are many changes. I suppose the easiest way to review will be going commit by commit. Describing main steps:
Profile
class based on Python API - e5162baResource
class based on Python implementation - b7d68a2DataPackage
class based on Python implementation - aa4b3a9I would say the codebase state before this PR was more like a prototype so I've just ported many things from Python codebase. It was easier than twaeking existent ones. Especially it's related to tests - we had a really small amount of them. So now it's covered much better and also it uses many Python test cases so we aim here cross-language consistency in behaviour.
During this work I've tweaked API based on previosly raised issues and improved readme - https://github.com/frictionlessdata/datapackage-js/tree/specs-v1#datapackage-js (could be a good review start).
That the last PR for core libs to specs-v1 update.