Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test for pipeline with code step #123

Merged
merged 3 commits into from
Aug 8, 2018

Conversation

OriHoch
Copy link
Contributor

@OriHoch OriHoch commented Mar 6, 2018

Seems the code step is not working, added a test to prove it

@OriHoch
Copy link
Contributor Author

OriHoch commented Mar 6, 2018

can see the failure here - https://travis-ci.org/frictionlessdata/datapackage-pipelines/builds/349780173#L971

E       AssertionError: Failed results: ['./tests/env/dummy/pipeline-test-code init, Invalid Pipeline: \'run\' is a required property\n\nFailed validating \'required\' in schema[\'properties\'][\'pipeline\'][\'items\']:\n    {\'properties\': {\'cache\': {\'type\': \'boolean\'},\n                    \'parameters\': {\'type\': \'object\'},\n                    \'run\': {\'type\': \'string\'},\n                    \'validate\': {\'type\': \'booelan\'}},\n     \'required\': [\'run\'],\n     \'type\': \'object\'}\n\nOn instance[\'pipeline\'][1]:\n    {\'code\': \'from datapackage_pipelines.wrapper import ingest, spew\\n\'\n             \'parameters, datapackage, resources, stats = ingest() + \'\n             \'({},)\\n\'\n             \'def get_resource():\\n\'\n             \'  for descriptor, resource in zip(datapackage["resources"], \'\n             \'resources):\\n\'\n             \'    for row in resource:\\n\'\n             \'      yield row\\n\'\n             \'spew(datapackage, [get_resource()], stats)\\n\'}']

@akariv
Copy link
Member

akariv commented Mar 6, 2018 via email

@OriHoch
Copy link
Contributor Author

OriHoch commented Mar 6, 2018

👍 fixed the test

@OriHoch OriHoch changed the title test problem with code step added test for pipeline with code step Mar 6, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 879

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 878: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@akariv akariv merged commit 5917d23 into frictionlessdata:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants