-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added test for pipeline with code step #123
Merged
akariv
merged 3 commits into
frictionlessdata:master
from
OriHoch:debugging-code-step-bug
Aug 8, 2018
Merged
added test for pipeline with code step #123
akariv
merged 3 commits into
frictionlessdata:master
from
OriHoch:debugging-code-step-bug
Aug 8, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can see the failure here - https://travis-ci.org/frictionlessdata/datapackage-pipelines/builds/349780173#L971
|
Yes, I think that originally it was used alongside the 'run' parameter and
not as a replacement.
We could modify the schema to require one of 'run' or 'code' to support
removing that parameter completely.
…On Tue, Mar 6, 2018 at 2:39 PM Ori Hoch ***@***.***> wrote:
can see the failure here -
https://travis-ci.org/frictionlessdata/datapackage-pipelines/builds/349780173#L971
E AssertionError: Failed results: ['./tests/env/dummy/pipeline-test-code init, Invalid Pipeline: \'run\' is a required property\n\nFailed validating \'required\' in schema[\'properties\'][\'pipeline\'][\'items\']:\n {\'properties\': {\'cache\': {\'type\': \'boolean\'},\n \'parameters\': {\'type\': \'object\'},\n \'run\': {\'type\': \'string\'},\n \'validate\': {\'type\': \'booelan\'}},\n \'required\': [\'run\'],\n \'type\': \'object\'}\n\nOn instance[\'pipeline\'][1]:\n {\'code\': \'from datapackage_pipelines.wrapper import ingest, spew\\n\'\n \'parameters, datapackage, resources, stats = ingest() + \'\n \'({},)\\n\'\n \'def get_resource():\\n\'\n \' for descriptor, resource in zip(datapackage["resources"], \'\n \'resources):\\n\'\n \' for row in resource:\\n\'\n \' yield row\\n\'\n \'spew(datapackage, [get_resource()], stats)\\n\'}']
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#123 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQMdUR6_ikhTxCmaTt7skETpSUGSG0aks5tboOSgaJpZM4Sel4u>
.
|
👍 fixed the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the
code
step is not working, added a test to prove it