Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support exclusion of directories from scanning for pipeline specs #143

Merged

Conversation

OriHoch
Copy link
Contributor

@OriHoch OriHoch commented Sep 12, 2018

All sub-directories are scanned for pipeline-specs, this is not optimal, especially with data directories contained under the project root directory.

Added support for exclusion of directory patterns (glob), by default, excluding .* directories and allowing to exclude additional patterns.

Uses os.walk support for modifying the directories that will be scanned by modifying the dirnames list in-place.

See updated README for usage details

@coveralls
Copy link

coveralls commented Sep 12, 2018

Pull Request Test Coverage Report for Build 1002

  • 70 of 188 (37.23%) changed or added relevant lines in 2 files are covered.
  • 45 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 17.568%

Changes Missing Coverage Covered Lines Changed/Added Lines %
datapackage_pipelines/utilities/dirtools.py 66 184 35.87%
Files with Coverage Reduction New Missed Lines %
datapackage_pipelines/specs/specs.py 1 79.49%
.tox/py36-plyvel/lib/python3.6/site-packages/datapackage_pipelines/specs/specs.py 22 0.0%
.tox/py36-sqlite/lib/python3.6/site-packages/datapackage_pipelines/specs/specs.py 22 0.0%
Totals Coverage Status
Change from base Build 1000: -0.3%
Covered Lines: 1731
Relevant Lines: 9853

💛 - Coveralls

@brew
Copy link
Contributor

brew commented Sep 12, 2018

Could this support an ignore file (like .dockerignore, .gitignore etc)? Perhaps .dpp_spec_ignore? Files to ignore seems like something you'd always want to do for all installations of a project, rather than something to configure for a specific installation in an env var.

@OriHoch
Copy link
Contributor Author

OriHoch commented Sep 12, 2018

thanks @brew yes, makes sense, I'll modify it

@OriHoch
Copy link
Contributor Author

OriHoch commented Sep 12, 2018

updated to use .dpp_spec_ignore file

@akariv
Copy link
Member

akariv commented Oct 3, 2018

@OriHoch can you please check why ci is failing?

@OriHoch OriHoch force-pushed the allow-to-ignore-spec-directories branch from 551760c to 178a2e5 Compare October 3, 2018 11:58
@OriHoch
Copy link
Contributor Author

OriHoch commented Oct 3, 2018

@akariv fixed

@akariv akariv changed the base branch from master to feature/v2.0.0 October 21, 2018 07:43
@akariv akariv changed the base branch from feature/v2.0.0 to master November 12, 2018 16:36
@akariv akariv merged commit 8a13e44 into frictionlessdata:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants