Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec step #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

exec step #152

wants to merge 2 commits into from

Conversation

OriHoch
Copy link
Contributor

@OriHoch OriHoch commented Oct 26, 2018

Added exec step which allows to run executables or shell scripts as part of the pipeline, see updated README and tests

@coveralls
Copy link

coveralls commented Oct 26, 2018 •
edited

Pull Request Test Coverage Report for Build 996

  • 3 of 17 (17.65%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-8.9%) to 17.83%
Changes Missing Coverage Covered Lines Changed/Added Lines %
datapackage_pipelines/lib/exec.py 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
.tox/py36-plyvel/lib/python3.6/site-packages/datapackage_pipelines/specs/resolver.py 11 0.0%
.tox/py36-sqlite/lib/python3.6/site-packages/datapackage_pipelines/specs/resolver.py 11 0.0%
Totals Coverage Status
Change from base Build 993: -8.9%
Covered Lines: 1666
Relevant Lines: 9344
💛 - Coveralls

@akariv
Copy link
Member

akariv commented Oct 26, 2018

This feels like it should be an extension and not part of the core lib.
That extension could have more than one exec, eg one for running pre commands, one for running finalization commands etc.

@roll roll added this to Software in Frictionless General Mar 19, 2019
@roll roll moved this from Software to In progress in Frictionless General Mar 19, 2019
@roll roll moved this from Pull Requests to Software in Frictionless General Mar 25, 2019
@roll roll added the wip label Apr 15, 2019
@roll roll moved this from Software to Software (contributors) in Frictionless General Jun 3, 2019
@roll roll removed the wip label Jun 3, 2019
@akariv akariv force-pushed the master branch 2 times, most recently from 154f0f1 to 62988ac Compare August 23, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Frictionless General
  
Software (wide)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OriHoch @coveralls @akariv @roll