Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify filtering out by multiple values. #154

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

jbothma
Copy link
Contributor

@jbothma jbothma commented Nov 12, 2018

While the implementation matches the logic in the documentation, I found it a bit unclear why my filter wasn't working.

I figured I'd make it really explicit for next time and to help others.

@coveralls
Copy link

coveralls commented Nov 12, 2018

Pull Request Test Coverage Report for Build 999

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-8.8%) to 17.897%

Files with Coverage Reduction New Missed Lines %
/home/travis/virtualenv/python3.6.3/lib/python3.6/distutils/init.py 18 49.32%
Totals Coverage Status
Change from base Build 993: -8.8%
Covered Lines: 1663
Relevant Lines: 9292

💛 - Coveralls

@akariv
Copy link
Member

akariv commented Nov 12, 2018

Thanks @jbothma , it's indeed more clear now.

@akariv akariv merged commit a3c6745 into frictionlessdata:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants