Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duplicate_to_end parameter #204

Merged
merged 3 commits into from Apr 16, 2021
Merged

Add duplicate_to_end parameter #204

merged 3 commits into from Apr 16, 2021

Conversation

cschloer
Copy link
Contributor

@cschloer cschloer commented Apr 7, 2021

Following the PR here: datahq/dataflows#156

@cschloer
Copy link
Contributor Author

cschloer commented Apr 7, 2021

@roll

@roll roll requested a review from akariv April 7, 2021 08:29
@akariv
Copy link
Member

akariv commented Apr 7, 2021

Looks good - just need to also bump dataflows version when it's released.

@cschloer
Copy link
Contributor Author

cschloer commented Apr 7, 2021

Dataflows version bumped!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1172

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 17.098%
Files with Coverage Reduction New Missed Lines %
.tox/py37-plyvel/lib/python3.7/site-packages/datapackage_pipelines/lib/duplicate.py 1 0%
.tox/py37-sqlite/lib/python3.7/site-packages/datapackage_pipelines/lib/duplicate.py 1 0%
Totals Coverage Status
Change from base Build 1166: 0.0%
Covered Lines: 1737
Relevant Lines: 10159
💛 - Coveralls

@cschloer
Copy link
Contributor Author

Bumping this @akariv

@akariv
Copy link
Member

akariv commented Apr 16, 2021

Sorry for the delay

@akariv akariv merged commit ad40bb8 into frictionlessdata:master Apr 16, 2021
akariv
akariv reviewed Apr 16, 2021
View reviewed changes
Copy link
Member

@akariv akariv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akariv
Copy link
Member

akariv commented Apr 16, 2021

https://pypi.org/project/datapackage-pipelines/2.2.6/

@cschloer
Copy link
Contributor Author

no worries for the delay! Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akariv akariv akariv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cschloer @akariv @coveralls