Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Package #46

Merged
merged 7 commits into from
Aug 12, 2017
Merged

Refactor Package #46

merged 7 commits into from
Aug 12, 2017

Conversation

georgiana-b
Copy link
Contributor

Fixes #32

I made all the changes listed there except update which doesn't seem needed in this case.

@georgiana-b georgiana-b requested a review from roll August 7, 2017 16:22
@georgiana-b
Copy link
Contributor Author

georgiana-b commented Aug 7, 2017 •
edited
Loading

@roll I implemented save() as in the JS library not as in the Python library, so in this case save just writes the descriptor to the datapackage file (e.g.datapackage.json).

@roll
Copy link
Member

roll commented Aug 9, 2017

@georgiana-b
Let's merge?

@georgiana-b georgiana-b merged commit f491c60 into master Aug 12, 2017
@georgiana-b georgiana-b deleted the feature/refactor_package branch August 12, 2017 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roll roll roll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgiana-b @roll