New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataPackage viewer: does not support csv dialect #16
Comments
@sirex you are quite right that this needed to be fixed - see existing TODO here https://github.com/frictionlessdata/datapackage-render-js/blob/master/datapackage.js#L143 This is actually a 10m job as all we need to do is convert arguments over to the ones that csv lib uses. If you are up for it PRs are very welcome. |
@sirex if you pull master now there should be delimiter support in. We are still working to support the rest of the dialect. |
References:
|
[#16,dp][m]: proper support for delimiter, quoteChar and escapeChar in csv dialect.
CSV dialect specifications mapping status with CSV Parser Options
Update |
Now irrelevant due to the library has changed - now focusing on utility functions for compiling and converting datapackage view specifications |
I have following resource definition:
But it looks, like DataPackage viewer ignores
dialect
. I tried same thing with Pythondatapackage
lib, it parses data correctly.Full example can be found here:
http://data.okfn.org/tools/view?url=https%3A%2F%2Fraw.githubusercontent.com%2Fsirex%2Ftransportas-velavimai%2Fmaster%2Fdatapackage.json#readme
And full
datapackage.json
can be found here:https://github.com/sirex/transportas-velavimai/blob/master/datapackage.json
The text was updated successfully, but these errors were encountered: