Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groupChar for integer field type #6

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

roll
Copy link
Member

@roll roll commented Jan 5, 2024


Rationale

Group char character is often used with integers similar to numbers. There is no reason to have this property for numbers but not to have it for integers.

@roll roll changed the title Support groupChar for integers Support groupChar for integer field type Jan 5, 2024
@nichtich
Copy link

nichtich commented Jan 9, 2024

The wording "This property does not have a default value" seems odd. I'd say it's just an optional property.

@roll
Copy link
Member Author

roll commented Jan 25, 2024

@nichtich
Thanks for pointing it out! The problem is that all these properties are optional by definition. Initially, it has a remark that the default value is null, which is not fully correct (it's not defined but not null). So I'm not sure how to phrase it.

My idea that we will go through wording on the next iteration as the project has a separate "Improve technical language" task while, currently, we need to make principal change decisions which require attention of the whole WG

@roll
Copy link
Member Author

roll commented Jan 25, 2024

BEING VOTED by WG (3/9)

cc @sapetti9 if we need to clarify acceptance criteria after adding a "neutral" voting option

@roll
Copy link
Member Author

roll commented Feb 19, 2024

@pschumm
@khusmann
@ezwelty
@PietrH
@nichtich
@peterdesmet
Would you consider changing (or adding) your vote to yes as currently we can't accept this change with 3 votes are missing? In my opinion this feature is no-brainer and honestly must-have that was missing for some weird reasons as without group char for integers it's just not possible to have any number like 1,000, 1,200,000 etc which is pretty common for data publishing in many countries

@roll roll added the candidate label Feb 19, 2024
@pschumm
Copy link

pschumm commented Feb 19, 2024

@pschumm Would you consider changing (or adding) your vote to yes as currently we can't accept this change with 3 votes are missing?

Changed my vote to yes (not sure at the moment why I hadn't voted that way before on this). Agreed it's both necessary and consistent.

@roll
Copy link
Member Author

roll commented Feb 19, 2024

Thanks!

ACCEPTED by the WG (6/9)

@roll roll merged commit d06cfe0 into main Feb 19, 2024
1 check passed
@roll roll deleted the 498/support-group-char-for-integers branch February 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support groupChar for integer type
3 participants