Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set profile to "tabular-data-package" when creating package #81

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

peterdesmet
Copy link
Member

Added resources will make the Data Package meet Tabular Data Package requirements, so profile is set to tabular-data-package. The property is not a requirement for check_package() (as incoming packages might not have it).

Setting profile makes for stronger validation for downstream users.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #81 (7f1f237) into main (f36b17f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7f1f237 differs from pull request most recent head 45cc810. Consider uploading reports for the commit 45cc810 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          418       419    +1     
=========================================
+ Hits           418       419    +1     
Impacted Files Coverage Δ
R/create_package.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c624515...45cc810. Read the comment docs.

@peterdesmet peterdesmet merged commit 471ad29 into main Jan 13, 2022
@peterdesmet peterdesmet deleted the tabular_data_package branch January 13, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant