GitHub hook: use sender login when username is not available (#323)

frictionlessdata · Apr 22, 2019 · 612a2e1 · 612a2e1
1 parent 36782b8
commit 612a2e1
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/goodtablesio/integrations/github/utils/hook.py b/goodtablesio/integrations/github/utils/hook.py
@@ -63,7 +63,10 @@ def get_details_from_hook_payload(payload):
             details['owner'] = payload['repository']['owner']['name']
             details['sha'] = payload['head_commit']['id']
             details['commit_message'] = payload['head_commit']['message']
-            details['author_name'] = payload['head_commit']['author']['username']
+            try:
+                details['author_name'] = payload['head_commit']['author']['username']
+            except KeyError:
+                details['author_name'] = payload['sender']['login']
             details['branch_name'] = payload['ref'].replace('refs/heads/', '')
 
     except KeyError:

diff --git a/goodtablesio/tests/integrations/github/utils/test_hook.py b/goodtablesio/tests/integrations/github/utils/test_hook.py
@@ -47,6 +47,27 @@ def test_get_details_from_hook_payload_PUSH():
         'branch_name': 'some-branch',
     }
 
+    payload = {
+      'ref': 'refs/heads/some-branch',
+      'repository': {'name': 'test-repo', 'owner': {'name': 'test-owner'}},
+      'head_commit': {
+          'id': 'test-sha',
+          'message': 'Test message',
+          'author': {
+              'name': 'no-username',
+          }},
+      'sender': {'login': 'test-user'},
+    }
+    assert get_details_from_hook_payload(payload) == {
+        'owner': 'test-owner',
+        'repo': 'test-repo',
+        'sha': 'test-sha',
+        'is_pr': False,
+        'commit_message': 'Test message',
+        'author_name': 'test-user',
+        'branch_name': 'some-branch',
+    }
+
 
 def test_get_details_from_hook_payload_PR():
     payload = {