Fixing json name of constraints

frictionlessdata · Sep 1, 2020 · 80cddb2 · 80cddb2
1 parent 3cc64ed
commit 80cddb2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/schema/field.go b/schema/field.go
@@ -109,7 +109,7 @@ type Field struct {
 
 	// Constraints can be used by consumers to list constraints for validating
 	// field values.
-	Constraints Constraints
+	Constraints Constraints `json:"constraints,omitempty"`
 }
 
 // UnmarshalJSON sets *f to a copy of data. It will respect the default values

diff --git a/schema/schema_test.go b/schema/schema_test.go
@@ -214,6 +214,11 @@ func TestRead_Sucess(t *testing.T) {
 			`{"fields":[{"name":"n1"}], "foreignKeys":{"reference":{"fields":["n1"]}}}`,
 			Schema{Fields: []Field{asJSONField(Field{Name: "n1"})}, ForeignKeys: ForeignKeys{Reference: ForeignKeyReference{Fields: []string{"n1"}}}},
 		},
+		{
+			"Constraints",
+			`{"fields":[{"name":"n1", "constraints":{"unique":true}}]}`,
+			Schema{Fields: []Field{asJSONField(Field{Name: "n1", Constraints: Constraints{Unique: true}})}},
+		},
 	}
 	for _, d := range data {
 		t.Run(d.Desc, func(t *testing.T) {
@@ -423,7 +428,7 @@ func TestValidate_Invalid(t *testing.T) {
 func TestWrite(t *testing.T) {
 	is := is.New(t)
 	s := Schema{
-		Fields:      []Field{{Name: "Foo"}, {Name: "Bar"}},
+		Fields:      []Field{{Name: "Foo", Constraints: Constraints{Unique: true}}, {Name: "Bar"}},
 		PrimaryKeys: []string{"Foo"},
 		ForeignKeys: ForeignKeys{Reference: ForeignKeyReference{Fields: []string{"Foo"}}},
 	}
@@ -434,11 +439,13 @@ func TestWrite(t *testing.T) {
     "fields": [
         {
             "name": "Foo",
-            "Constraints": {}
+            "constraints": {
+                "unique": true
+            }
         },
         {
             "name": "Bar",
-            "Constraints": {}
+            "constraints": {}
         }
     ],
     "primaryKey": [