Support Unique constrain.
#63
Conversation
schema/field.go
Outdated
| @@ -53,6 +53,10 @@ type Constraints struct { | |||
| // represent null values. | |||
| Required bool `json:"required,omitempty"` | |||
|
|
|||
| // Unique indicates whether this field is allowed to have duplicates. | |||
| // This constrain is only relevant for Schema.DecodeTable | |||
| Unique bool `json:"unique,omitempty"` | |||
schema/schema.go
Outdated
| elemp := reflect.New(elemt) | ||
| if err := s.Decode(iter.Row(), elemp.Interface()); err != nil { | ||
| return err | ||
| } | ||
| for _, k := range uniqueFieldIndexes { | ||
| if _, ok := uniqueCache[uniqueKey{k, elemp.Elem().Field(k).Interface()}]; ok { |
There was a problem hiding this comment.
Nit: Would you mind making a variable: field := elemp.Elem().Field(k) and making here and bellow a little simple?
schema/schema.go
Outdated
| @@ -332,6 +332,11 @@ func processPlaceholder(ph interface{}, v *[]string) error { | |||
| return fmt.Errorf("") | |||
| } | |||
|
|
|||
| type uniqueKey struct { | |||
There was a problem hiding this comment.
This is super nice, but not obvious for other contributors. Would you mind adding a comment explaining the reason for this data structure?
schema/schema_test.go
Outdated
| @@ -532,6 +532,43 @@ func TestDecodeTable(t *testing.T) { | |||
| t.Fatalf("err want:err got:nil") | |||
| } | |||
| }) | |||
| t.Run("UniqueConstrain", func(t *testing.T) { | |||
There was a problem hiding this comment.
Nit: t at the end.
Could you please name this Error_UniqueConstraint?
schema/schema_test.go
Outdated
| t.Fatalf("len(got) want:0 got:%v", len(got)) | ||
| } | ||
| }) | ||
| t.Run("PrimaryKeyAndUniqueConstrain", func(t *testing.T) { |
There was a problem hiding this comment.
Error_PrimaryKeyAndUniqueConstraint
schema/schema_test.go
Outdated
| @@ -532,6 +532,43 @@ func TestDecodeTable(t *testing.T) { | |||
| t.Fatalf("err want:err got:nil") | |||
| } | |||
| }) | |||
| t.Run("UniqueConstrain", func(t *testing.T) { | |||
There was a problem hiding this comment.
Could you either add or change other tests where the unique constraint does not error? (can be the Example_DecodeTable or something)
|
@danielfireman thank you for your effort on making this review. I have addressed all of your comments. |
This is for #47. In that issue python implementation was mentioned where uniqueness is checked for the field where this constraint is set and also for all PKs - in my implementation I did the same.