Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing decimal default in func castNumber. #70

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Fix missing decimal default in func castNumber. #70

merged 2 commits into from
Mar 4, 2019

Conversation

russmack
Copy link
Contributor

@russmack russmack commented Mar 4, 2019 •
edited by danielfireman
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Mar 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-2.8%) to 92.804% when pulling 6447c0d on russmack:fix-missing-decimal-default into aaf4dd3 on frictionlessdata:master.

danielfireman
danielfireman requested changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@danielfireman danielfireman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! Thanks for fixing this.

Could you please add a test entry to TestCastNumber?

@danielfireman danielfireman merged commit 78f348b into frictionlessdata:master Mar 4, 2019
@danielfireman
Copy link
Collaborator

Thanks a lot for this!

Pushed a version 1.11 with this fix.

@russmack
Copy link
Contributor Author

russmack commented Mar 4, 2019

Thanks for building it! It's just what I need for a current migration.

@russmack russmack deleted the fix-missing-decimal-default branch May 5, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfireman danielfireman danielfireman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russmack @coveralls @danielfireman