Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom sample limit. #72

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Add custom sample limit. #72

merged 3 commits into from
Mar 6, 2019

Conversation

russmack
Copy link
Contributor

@russmack russmack commented Mar 5, 2019 •
edited by danielfireman
Loading

This enables specifying the infer sample limit to be a value other than the default 100.

I need this feature now, so have gone ahead and implemented it, but am happy to change it as required.

One reason I needed it was to help debug #71

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 92.0% when pulling 249b479 on russmack:add-custom-sample-limit into 78f348b on frictionlessdata:master.

@coveralls
Copy link

coveralls commented Mar 5, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.04%) to 91.765% when pulling 3b2c89d on russmack:add-custom-sample-limit into 78f348b on frictionlessdata:master.

danielfireman
danielfireman requested changes Mar 5, 2019
View reviewed changes
Copy link
Collaborator

@danielfireman danielfireman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Only minor fixes before get it in.

examples/infer/main.go Outdated Show resolved Hide resolved
schema/infer.go Show resolved Hide resolved
@danielfireman danielfireman merged commit 22fcea0 into frictionlessdata:master Mar 6, 2019
@russmack russmack deleted the add-custom-sample-limit branch May 5, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfireman danielfireman danielfireman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russmack @coveralls @danielfireman