Fixed string type (#76)

frictionlessdata · Jun 24, 2017 · b3f8393 · b3f8393
1 parent 4192872
commit b3f8393
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -13,4 +13,5 @@ coverage/
 # A browser distribution is built in `dist` when pushing to npm.
 dist/
 # Code transpiled to ES5 is built in `lib` when pushing to npm.
-lib/
+lib/
+package-lock.json
diff --git a/package.json b/package.json
@@ -24,7 +24,7 @@
   },
   "devDependencies": {
     "babel": "^6.5.2",
-    "babel-cli": "^6.8.0",
+    "babel-cli": "^6.24.1",
     "babel-istanbul": "^0.8.0",
     "babel-loader": "^6.2.1",
     "babel-plugin-transform-es2015-arrow-functions": "^6.8.0",

diff --git a/src/types.js b/src/types.js
@@ -168,7 +168,7 @@ class StringType extends Abstract {
   }
 
   typeCheck(value) {
-    if (utilities.isNumeric(value) || typeof value !== 'string') {
+    if (typeof value !== 'string') {
       throw new Error()
     }
     return true

diff --git a/test/types.js b/test/types.js
@@ -184,6 +184,10 @@ describe('Types', () => {
       assert.isTrue(type.test(BASE_FIELD, value))
       done()
     })
+
+    it('cast numbers presented as strings to strings', () => {
+      assert.equal(type.cast(BASE_FIELD, '001'), '001')
+    })
   })
 
   describe('IntegerType', () => {